Fix default SDFGI variant not being compiled in time. #102122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101826.
There was a possible race condition between the SDFGI variant for the material being compiled in time and this uniform setup function using it. Technically, retrieving the shader variant before the group is enabled is not valid behavior under the new design. Getting the shader variant after the group is enabled guarantees there won't be a race condition, but getting the variant before that only returns a placeholder but the shader isn't guaranteed to be filled out.
Pretty much no other code does something like this so the issue was very isolated to this particular case, so the fix is just to defer the retrieval of the variant until it's actually necessary and ensure the shader group is initialized before doing so.