Change if false to if true "Emoji and Symbols" menu is enabled.

[ChildLearningClub]

Under LineEdit Class Emoji Menu Enabled Property

Will now read: If true, "Emoji and Symbols" menu is enabled.

[bruvzg]

TextEdit.xml have the same line, and also should have true.

[ChildLearningClub]

TextEdit.xml have the same line, and also should have true.

Should I go ahead and do the same for this? @bruvzg

[bruvzg]

Should I go ahead and do the same for this?

Yes.

[ChildLearningClub]

okay made the changes to the file and ran git add . and git commit again but still only show this pull request? Sorry first time?
Edit: never mind didn't git push

[bruvzg]

Please squash the commits, see Pull request workflow for details.

[ChildLearningClub]

Okay, think i did that right?

[bruvzg]

Okay, think i did that right?

Commit message still have text from both old commits:

Changed if false to if true "Emoji and Symbols" menu is enabled.
Changed if false to if true "Emoji and Symbols" menu is enabled. Squashed into commit 1

Pleas amend it to Changed if false to if true "Emoji and Symbols" menu is enabled.. Everything else seems to be OK.

[ChildLearningClub]

How does this look now?

[bruvzg]

Something gone wrong, seems like you have merged msater instead of rebasing.

[ChildLearningClub]

I hope what I did fixed it?

git log --oneline

eef17e0c35 (HEAD -> master, origin/master, origin/HEAD) Changed if false to if true "Emoji and Symbols" menu is enabled.b15b24b087 (upstream/master) Merge pull request #101688 from TCROC/fix-gpu-particles-2d-set_one_shot-seed-randomization
b298f6f479 Merge pull request #101936 from Hilderin/disable-game-embedding-single-window-mode

git reset --hard eef17e0c35

git checkout master

then I did a git fetch origin, git rebase origin/master and lastly, git push --force.

[akien-mga]

then I did a git fetch origin, git rebase origin/master and lastly, git push --force.

This didn't work, because your origin is your own fork, so rebasing on origin/master is rebasing on the branch you used to make this PR (so no change).

You need to add the upstream Godot repo as a remote and rebase on top of that one:

git remote add upstream https://github.com/godotengine/godot
git fetch upstream master
git rebase upstream/master
git push --force

I did this locally and updated your fork's branch directly (GitHub allows maintainer to do this by default, unless disabled when opening the PR).

One last thing before merging:

Your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

You can add the email used for this commit in your GitHub settings and it should then appear as authored by you. Alternatively the email can be changed to your GitHub account's anonymous email, I can do this if you want.

[ChildLearningClub]

I updated my email to match the git config, thank you. Definitely need to get more familiar with the whole Git process.

[Repiteo]

Thanks! Congratulations on your first merged contribution! 🎉

[ChildLearningClub]

I really appreciate all the work everyone is putting into this project, Thank you! A really great program and community, I’m happy to be part of it :)