[FreeDesktop portal] Check for FileChooser and Settings interface availability instead of assuming it's always available.
#101812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riteo
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Code looks good and stuff seems to work, although I still get a "no such interface" error for settings. Apparently it's because not everything checks for is_dark_mode_supported. Maybe we should embed the is_settings_supported check in is_dark_mode and if it fails return false?
… availability instead of assuming it's always available.
|
Added check to |
Riteo
approved these changes
Jan 31, 2025
akien-mga
approved these changes
Jan 31, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent issues with native file dialogs on broken XDG configs.
Instead of assuming XDG portal is always fully available as long as D-Bus is, adds version checks for
FileChooserandSettingsinterfaces tohas_featureandis_dark_mode_supported. Also fixesFEATURE_TEXT_TO_SPEECHhanding on X11.