Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize calls of utf8 in a few spots to avoid calling it more than once. #101233

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Optimize calls of utf8 in a few spots to avoid calling it more than once. #101233

merged 1 commit into from
Jan 9, 2025

Conversation

Ivorforce
Copy link
Contributor

Kind of a follow-up to #99893.

For the record, I used the following search key to find more instances of the same problem:

(\w+)\.utf8\(\)(.|\n)*\1\.utf8

@Ivorforce Ivorforce requested review from a team as code owners January 7, 2025 16:28
@Chaosus Chaosus modified the milestones: 4.4, 4.x Jan 7, 2025
@bruvzg bruvzg modified the milestones: 4.x, 4.4 Jan 8, 2025
@akien-mga akien-mga merged commit 3ac4da1 into godotengine:master Jan 9, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Ivorforce Ivorforce deleted the utf8-multicall branch January 9, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiroxas kiroxas kiroxas approved these changes

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
enhancement platform:linuxbsd topic:core
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Ivorforce @akien-mga @kiroxas @bruvzg @Chaosus