-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign the project manager title to the node instead of DisplayServer #100745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title is now Godot Engine - Project Manager (DEBUG)
.
The main window's title always has this (DEBUG)
suffix for debug builds. The same goes for official builds too since debugging features are enabled when compiling the editor.
I think that's why the title was set on DisplayServer
instead of Window
.
I'm sorry, is that not wanted behavior ? |
Yes. That's the previous behavior. Editor builds always define |
@timothyqiu I proposed a fix, can you tell me if that sounds correct to you. If that's ok, I'll squash everything. |
5e360f1
to
83e7440
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected.
e5ec66c
to
51cc14a
Compare
I have added a comment on excluding the project manager for the |
…e instead of DisplayServer
51cc14a
to
e4e966b
Compare
Thanks! |
Fixes #100727
Project Manager title is directly given to the
DisplayServer
at initialization.With the changes of ff6eea5 auto-translation triggers the renaming of the window and leading to the bug since the
title
attribute of the scene root was not defined.This fix gives the title to the root of the
SceneTree
which solves the problem.