-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jolt: Update to commit f094082aa, adding RISC-V, PPC64 and LoongArch support #100561
base: master
Are you sure you want to change the base?
Conversation
9fa6da8
to
d243302
Compare
Jolt supports rv32 and rv64 as of jrouwe/JoltPhysics#1400 we should note that and when we update Jolt update this list of archs. It'd be nice to support these as our friendly neighborhood open source cpu arch :) |
d243302
to
3861470
Compare
I backported JoltPhysics#1400 to add RISC-V support, so now this PR only disables the module for |
Any reason why we wouldn't just update Jolt as a whole instead? The currently pinned version is largely just an arbitrary commit from Jolt's |
Yeah we can do that too, I just haven't evaluated whether there's been any other upstream changes that might be a bit risky to use in production. Usually we prefer to stick to tagged releases but I see we're already on a dev commit so we might as well update further. |
3861470
to
0926be3
Compare
Might be good to bump it by one more commit, to jrouwe/JoltPhysics@27559da, just in case anyone runs into problems with the MSVC warning mentioned in jrouwe/JoltPhysics#1402. |
Yeah, and I see jrouwe/JoltPhysics#1377 was reopened so I was thinking of waiting for that one to be merged too to sync. |
Yes, please give me a couple of days. I'll get PPC and LoongArch support in there too. I'll ping this thread when it's done. |
Sounds good! No rush from our side, this is still a mostly theoretical ask and nothing urgent to solve. |
PowerPC support has been merged, only Little Endian mode works atm. Big Endian compiles but fails the unit tests. |
LoongArch support has also been added to Jolt. I think this PR can now be updated to the latest version of Jolt and merged. |
0926be3
to
1c669d7
Compare
Amazing work, thanks a lot @jrouwe! The PR was updated to simply update Jolt Physics to jrouwe/JoltPhysics@f094082. We're still disabling the Jolt module for |
1c669d7
to
4727f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Was wondering why ppc32 was excluded, but I see now that it doesn't support 8 byte atomics, so this is indeed the best we can do. |
Fixes #100557.