Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Timer error on startup #100530

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 17, 2024

@KoBeWi KoBeWi added this to the 4.4 milestone Dec 17, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner December 17, 2024 20:43
@Mickeon
Copy link
Contributor

Mickeon commented Dec 17, 2024

It does fix the error, but it's a bit hacky, as before. It's also a bit inconsistent with the set_warning_count(0); below which may make this harder to follow. As I mentioned once, perhaps it's better to just bite the bullet and fetch the editor setting in the constructor...?

@KoBeWi
Copy link
Member Author

KoBeWi commented Dec 17, 2024

Yeah that's an alternative.

@KoBeWi KoBeWi force-pushed the fix_hack…_with_a_hack branch from 7d18d67 to a200885 Compare December 17, 2024 20:54
@KoBeWi
Copy link
Member Author

KoBeWi commented Dec 17, 2024

Pushed a different fix.

@KoBeWi KoBeWi force-pushed the fix_hack…_with_a_hack branch from a200885 to de048ef Compare December 17, 2024 20:55
@KoBeWi KoBeWi force-pushed the fix_hack…_with_a_hack branch from de048ef to 0ffdb6b Compare December 17, 2024 21:27
@akien-mga akien-mga merged commit abf4796 into godotengine:master Dec 17, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the fix_hack…_with_a_hack😎 branch December 17, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants