Cleanup despaghettify NavigationServer path queries #100469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unused function parameters, moves some to the query task, renames functions for consistency and grouping.
kiroxas
approved these changes
Dec 16, 2024
| uint32_t link_polygons_size = 0; | ||
| const gd::Polygon *begin_poly = nullptr; | ||
| const gd::Polygon *end_poly = nullptr; | ||
| Vector3 begin_point; |
There was a problem hiding this comment.
Maybe add some comments here, or an overview, of what those are used for. It's not clear what is the difference between begin_point and begin_position
There was a problem hiding this comment.
Need to change that. This is actual leftover from trying to rename those in the original PR.
|
Closing as I added the fixes and renames to the PR #100497 so I dont need to keep both in sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused function parameters, moves some to the query task, renames functions for consistency and grouping.
This is followup-cleanup of PR #100129.
At that time that PR was already so convoluted I did not want to touch it anymore and risk changes.