Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Noise virtual so custom noises can be created #100443

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zylann
Copy link
Contributor

@Zylann Zylann commented Dec 15, 2024

This allows scripts and GDExtensions to implement custom noises.

@Zylann Zylann requested a review from a team as a code owner December 15, 2024 18:00
@Zylann Zylann requested a review from a team as a code owner December 15, 2024 19:07
@Chaosus Chaosus added this to the 4.4 milestone Dec 16, 2024
modules/noise/noise.h Outdated Show resolved Hide resolved
@Zylann
Copy link
Contributor Author

Zylann commented Dec 16, 2024

I would like to also expose get_image, in particular for implementations that can use SIMD. But I'm not sure what to do about the skirt parameter. It doesnt always make sense to use it, as some implementations can generate seamless noise natively and don't even need a skirt. Should I expose it as-is anyways?

@Mickeon
Copy link
Contributor

Mickeon commented Dec 16, 2024

The parameter can just be ignored if need to be. It happens all the time in user code for _physics_process & similar.

@Zylann Zylann force-pushed the noise_extension branch 2 times, most recently from af1ea46 to bc1c843 Compare December 16, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants