Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename animation node process function to avoid GDExtension name collision #100442

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Rename animation node process function to avoid GDExtension name collision #100442

merged 1 commit into from
Dec 16, 2024

Conversation

GuilhermeGSousa
Copy link
Contributor

No description provided.

@GuilhermeGSousa GuilhermeGSousa requested review from a team as code owners December 15, 2024 17:23
@GuilhermeGSousa GuilhermeGSousa mentioned this pull request Dec 15, 2024
Merged
1 task
@GuilhermeGSousa GuilhermeGSousa force-pushed the rename-animation-node-process branch from 6a32808 to 469f5a8 Compare December 15, 2024 17:27
fire
fire approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TokageItLab Can you look too?

@fire fire changed the title Rename animation node process function Rename animation node process function to avoid gdextension name collision Dec 15, 2024
@fire fire requested a review from a team December 15, 2024 17:39
@akien-mga akien-mga added this to the 4.4 milestone Dec 16, 2024
@Repiteo Repiteo merged commit b1fb0f5 into godotengine:master Dec 16, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 16, 2024

Thanks!

@GuilhermeGSousa GuilhermeGSousa deleted the rename-animation-node-process branch December 16, 2024 23:34
@akien-mga akien-mga changed the title Rename animation node process function to avoid gdextension name collision Rename animation node process function to avoid GDExtension name collision Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@dsnopek dsnopek dsnopek approved these changes

@TokageItLab TokageItLab TokageItLab approved these changes

Assignees
No one assigned
Labels
enhancement topic:animation
Projects
Animation Team Issue Triage
Status: Done
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@GuilhermeGSousa @Repiteo @fire @dsnopek @TokageItLab @akien-mga