-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename String::copy_from
functions to their respective encodings (parse_latin1
, parse_wstring
, parse_utf32
).
#100434
Conversation
String::copy_from
to their respective encodings (parse_latin1
, parse_wstring
, parse_utf32
)String::copy_from
functions to their respective encodings (parse_latin1
, parse_wstring
, parse_utf32
)
d934814
to
1fc7223
Compare
String::copy_from
functions to their respective encodings (parse_latin1
, parse_wstring
, parse_utf32
)String::copy_from
functions to their respective encodings (parse_ascii
, parse_wstring
, parse_utf32
). Fix parse_ascii
having undefined behavior above 127.
1fc7223
to
7ab35ba
Compare
String::copy_from
functions to their respective encodings (parse_ascii
, parse_wstring
, parse_utf32
). Fix parse_ascii
having undefined behavior above 127.String::copy_from
functions to their respective encodings (parse_latin1
, parse_wstring
, parse_utf32
).
7ab35ba
to
cd3967f
Compare
MSVC is failing due to the
|
cd3967f
to
03a8f7d
Compare
…parse_latin1`, `parse_wstring`, `parse_utf32`).
03a8f7d
to
df3e929
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming makes sense.
@@ -33,6 +33,7 @@ | |||
|
|||
#ifdef GLES3_ENABLED | |||
|
|||
#include "drivers/gles3/shader_gles3.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover? How it is related to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He explained it in a comment in the PR.
Is it failing locally on a clean build, or only on CI build? |
It's a cache problem; it's not failing for clean builds. Touching the file in any way is enough to wipe the cache and get the builds to pass. I don't know if it can fail locally as well. I've been in talks with the SCons maintainers to get it fixed, but I haven't managed to make an MRP (because I don't use MSVC). |
Thanks! |
The functions are doing interpretation work, not just blind copying, so they should be renamed to reflect what they actually do.
I chose the
parse_
prefix to match the existingparse_utf8
andparse_utf16
:godot/core/string/ustring.h
Lines 527 to 531 in b9437c3
Arguably, the interfaces should be made to match and the functions exposed to public, but this would be for another PR. In this one, I'm just trying to clear up semantics a bit, which should be uncontroversial.