Fix occlusion culling buffer getting overwritten in larger scenes #100060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100032
On subsequent calls to
_transform_vertices_range()
(wherep_from
would have been adjusted) it would still start writing to the same index in ofxformed_vertices
effectively overwriting and corrupting vertex data previously written.The correct implementation is to offset
p_write
with 3*p_from
.I tested using occlusion_culling_mesh_lod for both double and float builds.
Before:

After:
