Fix AnimatableBody sync to physics #100056
Open
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
huwpascoe
commented
Dec 5, 2024
•
huwpascoe
commented
- Fixes AnimatableBody2D animates only one property when sync_to_physics is enabled (using AnimationPlayer) #98970
- Fixes AnimatableBody3D can't rotate and move at the same time #91801
- Fixes Updating rotation and position of AnimatableBody2D in code only updates using the last instruction when sync to physics is enabled #76685
- Fixes 3D: When "Sync to Physics" enabled on KinematicBody, animation of translation and rotation doesn't work correctly. #58915
Mickeon
reviewed
Dec 5, 2024
| @@ -87,9 +89,9 @@ void AnimatableBody2D::_notification(int p_what) { | |||
|
|
|||
| case NOTIFICATION_LOCAL_TRANSFORM_CHANGED: { | |||
| // Used by sync to physics, send the new transform to the physics... | |||
| Transform2D new_transform = get_global_transform(); | |||
| next_transform = next_transform * last_valid_transform.affine_inverse() * get_global_transform(); | |||
There was a problem hiding this comment.
In my uttermost ignorance of the topic, why... why does this work?
There was a problem hiding this comment.
Essentially, it adds the difference.
diff = global - last_valid
next = next + diff
Shorthand
next += global - last_valid
Could also write it like this
next += (-last_valid) + global
or this
next += inverse(last_valid) + global
But these are transform matrix, need to combine them with a special * operator.
next = next * inverse(last_valid) * global
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.