-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Godot will throw errors infinitely when Windows audio driver was once used by another app #99968
Comments
Tested on Win 10 with Adobe Audition and Premiere Pro at the same time with a Godot editor + running project (4.4 dev 5) with audio and I could not reproduce the error. (my audio output device is a USB Sound Blaster Play 3) |
My audio is Realtek ALC1220 based, and the issue appeared with Vegas Pro 21 |
Duplicate of #18732 (though maybe that issue should emphasize the fact that the error spams). |
I've created PR #100116 to address the error spam in the Godot editor. If anyone is available for testing this fix, you can download an editor build from the artifacts on the checks page of the PR. |
Fixes godotengine#99968 and prevents the error spam referenced in comments of godotengine#18732. Also fixes a number of memory leaks that occur when an audio device is reinitialized or fails to reinitialize and gates reinitialization attempts to around 1 per second instead of ~1000 attempts per second. Co-authored-by: Kusok <[email protected]>
Fixes godotengine#99968 and prevents the error spam referenced in comments of godotengine#18732. Also fixes a number of memory leaks that occur when an audio device is reinitialized or fails to reinitialize and gates reinitialization attempts to around 1 per second instead of ~1000 attempts per second. Co-authored-by: Kusok <[email protected]>
Fixes godotengine#99968 and prevents the error spam referenced in comments of godotengine#18732. Also fixes a number of memory leaks that occur when an audio device is reinitialized or fails to reinitialize and gates reinitialization attempts to around 1 per second instead of ~1000 attempts per second. Co-authored-by: Kusok <[email protected]>
Tested versions
Godot 4.3 Stable
System information
Windows 10 x64
Issue description
When another app (like audio or video editing software) uses Windows Audio system, Godot begin to throw errors and will not stop until it will be fully closed and reopened. Even if another app is already closed and is no longer using the driver.
Steps to reproduce
Open Godot
Open Vegas Pro or other video editing app at the same time
Minimal reproduction project (MRP)
N/A (and not required)
The text was updated successfully, but these errors were encountered: