Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot will throw errors infinitely when Windows audio driver was once used by another app #99968

Closed
ArseniyMirniy opened this issue Dec 3, 2024 · 4 comments · Fixed by #100116

Comments

@ArseniyMirniy
Copy link

Tested versions

Godot 4.3 Stable

System information

Windows 10 x64

Issue description

When another app (like audio or video editing software) uses Windows Audio system, Godot begin to throw errors and will not stop until it will be fully closed and reopened. Even if another app is already closed and is no longer using the driver.

Image

Steps to reproduce

Open Godot
Open Vegas Pro or other video editing app at the same time

Minimal reproduction project (MRP)

N/A (and not required)

@htmiel
Copy link

htmiel commented Dec 3, 2024

Tested on Win 10 with Adobe Audition and Premiere Pro at the same time with a Godot editor + running project (4.4 dev 5) with audio and I could not reproduce the error.

(my audio output device is a USB Sound Blaster Play 3)

@ArseniyMirniy
Copy link
Author

Tested on Win 10 with Adobe Audition and Premiere Pro at the same time with a Godot editor + running project (4.4 dev 5) with audio and I could not reproduce the error.

(my audio output device is a USB Sound Blaster Play 3)

My audio is Realtek ALC1220 based, and the issue appeared with Vegas Pro 21

@jitspoe
Copy link
Contributor

jitspoe commented Dec 5, 2024

Duplicate of #18732 (though maybe that issue should emphasize the fact that the error spams).

@allenwp
Copy link
Contributor

allenwp commented Dec 6, 2024

I've created PR #100116 to address the error spam in the Godot editor. If anyone is available for testing this fix, you can download an editor build from the artifacts on the checks page of the PR.

@akien-mga akien-mga added this to the 4.4 milestone Jan 14, 2025
Splizard pushed a commit to grow-graphics/godot that referenced this issue Feb 2, 2025
Fixes godotengine#99968 and prevents the error spam referenced in comments of godotengine#18732.
Also fixes a number of memory leaks that occur when an audio device is reinitialized or fails to reinitialize and gates reinitialization attempts to around 1 per second instead of ~1000 attempts per second.

Co-authored-by: Kusok <[email protected]>
tGautot pushed a commit to tGautot/godot that referenced this issue Feb 5, 2025
Fixes godotengine#99968 and prevents the error spam referenced in comments of godotengine#18732.
Also fixes a number of memory leaks that occur when an audio device is reinitialized or fails to reinitialize and gates reinitialization attempts to around 1 per second instead of ~1000 attempts per second.

Co-authored-by: Kusok <[email protected]>
tGautot pushed a commit to tGautot/godot that referenced this issue Feb 5, 2025
Fixes godotengine#99968 and prevents the error spam referenced in comments of godotengine#18732.
Also fixes a number of memory leaks that occur when an audio device is reinitialized or fails to reinitialize and gates reinitialization attempts to around 1 per second instead of ~1000 attempts per second.

Co-authored-by: Kusok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants