Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon_hover_pressed_color⁠ not working for Buttons #98139

Open
berkeerkeskin opened this issue Oct 13, 2024 · 3 comments
Open

icon_hover_pressed_color⁠ not working for Buttons #98139

berkeerkeskin opened this issue Oct 13, 2024 · 3 comments

Comments

@berkeerkeskin
Copy link

Tested versions

Reproducable in 4.3.stable

System information

Godot v4.3.stable - macOS 14.1.0 - Vulkan (Forward+) - integrated Apple M3 Max - Apple M3 Max (14 Threads)

Issue description

Using ⁠ icon_hover_pressed_color either as a theme override or part of a theme itself does not work. I have a toggleable button in my scene that I've attached an icon to and every time its pressed state changes to true it becomes impossible to notice a colour change upon hovering it even though I have a value set for ⁠ icon_hover_pressed_color.

Steps to reproduce

1.⁠ ⁠Add a Button node to a scene
2.⁠ ⁠Attach an icon to the Button
3.⁠ ⁠Set an icon_hover_pressed_color theme override
4.⁠ ⁠Play the scene and try hovering over the button to notice a colour change

Minimal reproduction project (MRP)

N/A

@bruvzg
Copy link
Member

bruvzg commented Oct 13, 2024

Seems like it only works if hover_pressed style box is set, and by default it is set only for CheckButton and CheckBox, but not for Button.

@Gurka2
Copy link

Gurka2 commented Oct 14, 2024

I would like to give this issue a try, seems like good first issue to me :D

@SlienCode
Copy link
Contributor

This is related to #83393

I've already proposed a fix in my pull request #97335

For the time being you can try using a hovered_pressed style box alongside your color override which fixes the issue till the pull request gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants