Physics interpolation: Per node disabling in editor broken

[lubasowo0]

Tested versions

4.3.dev [29b3d9e] and [06abc86]

System information

Arch Linux - OpenGL API 4.6 (Core Profile) Mesa 24.0.4-arch1.2

Issue description

Not the main issue but On and Off in this line are swapped:

godot/scene/main/node.cpp

Line 3783 in 79de2ea

ADD_PROPERTY(PropertyInfo(Variant::INT, "physics_interpolation_mode", PROPERTY_HINT_ENUM, "Inherit,Off,On"), "set_physics_interpolation_mode", "get_physics_interpolation_mode");

The issue is that enabling Physics Interpolation in the project settings and then disabling it per node in the editor doesn't do anything, probably because canvas_item_set_interpolated never gets called at startup. Here are some workarounds I found which fix the issue:

• Commenting out this early return:

  godot/scene/main/node.cpp

  Line 421 in 79de2ea

  if (data.physics_interpolated == p_interpolated) {

• Calling canvas_item_set_interpolated manually:

func _ready() -> void:
	RenderingServer.canvas_item_set_interpolated(get_canvas_item(), false)

• Setting PHYSICS_INTERPOLATION_MODE_OFF at runtime:

func _ready() -> void:
	#PHYSICS_INTERPOLATION_MODE_OFF is NOT set in the editor, if it is this doesn't work,
	#probably because of early returns
	physics_interpolation_mode = PHYSICS_INTERPOLATION_MODE_OFF

Steps to reproduce

• enable Physics Interpolation and set low ticks per seconds, for example 5
• add Sprite2d with a script to update a position in _process (not _physics_process) to introduce visible jitter with interpolation and low ticks per seconds
• in editor disable the interpolation for the sprite (options are swapped without fixing that line above)
• the sprite still jitters

Minimal reproduction project (MRP)

project.zip

[github-actions]

Hello from the maintainer team!

First of all, thank you for taking the time to report an issue here.

In case you haven't already, be sure to attach an MRP (minimal reproduction project) if specific steps or assets are needed in order to reproduce the issue. Contributors will use the MRP to validate that the fix is working as intended.

The time it will take to assess and fix your issue may vary. Follow the blog about our new releases and pre-releases to track new fixes or go to our forum where users could help you in the meantime.

Thank you for your patience.

[lawnjelly]

This bug is not present in 3.x, just tested. @rburing
I'll try and help but may be away for few days. It is probably something very simple.

UPDATE:
It's probably this:
data.physics_interpolated defaults to false in 4.x, and true in 3.x.

godot/scene/main/node.cpp

Line 3836 in 79de2ea

data.physics_interpolated = false;

(I can't test and make PR due to lack of time, but feel free. 👍 )

[rburing]

Thanks a lot for catching this during the dev phase! 👍