scene\resources\text_paragraph.cpp:420 - Condition "p_font.is_null()" is true. Returning: false on editor startup

[chrisl8]

Tested versions

Starting with Commit 86415f0

System information

Godot v4.3.dev (86415f0) - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 Ti (NVIDIA; 31.0.15.5186) - AMD Ryzen 9 5900X 12-Core Processor (24 Threads)

Issue description

I see this error on every startup, even with an empty project:

scene\resources\text_paragraph.cpp:420 - Condition "p_font.is_null()" is true. Returning: false

Steps to reproduce

Start a new empty project with Godot at commit 86415f0 or later

Minimal reproduction project (MRP)

Any empty project will do it.

[chrisl8]

It seems to be this line

godot/editor/debugger/editor_debugger_tree.cpp

Line 44 in 86415f0

set_auto_translate_mode(AUTO_TRANSLATE_MODE_DISABLED);

Removing it makes the error go away, but I'm just easter egging here without understanding the ramifications.

[MarkoSFG]

Moving the call

set_auto_translate_mode(AUTO_TRANSLATE_MODE_DISABLED);

from EditorDebuggerTree::EditorDebuggerTree() constructor to the bottom of EditorDebuggerNode:EditorDebuggerNode() fixes the issue, add

remote_scene_tree->set_auto_translate_mode(AUTO_TRANSLATE_MODE_DISABLED);

to bottom of that EditorDebuggerNode constructor instead.

(in other words the call to prevent auto translate happens too early at the moment)

[MarkoSFG]

@akien-mga can you take a look please?

[timothyqiu]

Probably the same cause as described in #89804 (comment).

NOTIFICATION_TRANSLATION_CHANGED could be propagated from parent nodes now, so we either avoid assuming theme caches are ready during the notification, or we avoid changing this property in the nodes' own constructor.

godot/scene/gui/tree.cpp

Lines 4350 to 4354 in 29b3d9e

	case NOTIFICATION_THEME_CHANGED:
	case NOTIFICATION_LAYOUT_DIRECTION_CHANGED:
	case NOTIFICATION_TRANSLATION_CHANGED: {
	_update_all();
	} break;

The initial theme cache update is in NOTIFICATION_POSTINITIALIZE. So moving the call outside the constructor works.