[4.3 Dev 3] Undo in Script Editor is dangerously dysfunctional (OK in 4.2) #89060
Comments
Did you mean 4.2? :P |
|
Please test 4.3-dev4, I've seen report of such an issue fixed in that snapshot. |
|
Yes.
…On Sat, Mar 2, 2024 at 6:27 AM Riteo ***@***.***> wrote:
not in 4.3
Did you mean 4.2? :P
—
Reply to this email directly, view it on GitHub
<#89060 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANACTLOD5ZRKGO3C7BKZXLYWHHS5AVCNFSM6AAAAABECIJ6C2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZUG44TOMBUGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@akien-mga just tested in |
|
Closed as fixed in 4.3-dev4. @daviesaz Please let us know if you still reproduce the issue in that version or later ones. |
|
I've got no clue what was going on here, but both dev5 and master have been very problematic for me. I can't get the script editor to undo, nor can I even close the current script. Even if I remap the Close Scene shortcut (why was it changed??) all that CMD+W does is stop inspecting the current resource. Very unfortunate, I'm liking the other GUI changes that I've noticed in 4.3, but there's something seriously wrong with the script editor. |
I just tried 4.3-dev4, and everything works as expected with it. Even 4.3-dev3 has better behavior than 4.3-dev5, as at least I can close the script in that version, but it's otherwise the same deal as 4.3-dev3. There must have been some regression between 4.3-dev4 and 4.3-dev5. |
|
@caimantilla It looks like the Close Scene shortcut was changed in #88913 |
From what I remember, close script didn't even work after I changed the close scene keybind back to the old one. Just think the script editor isn't receiving shortcuts at all |
|
Also seeing this, the bug from 4.3dev3 where undo in the script editor instead undid changes in open scenes was fixed in 4.3dev4, but is now back again in 4.3dev5. Interestingly it seems specific to undo/redo. Other keyboard shortcuts like copy/paste correctly target the active script editor. |
|
Confirmed. In a fresh project, create a Node2D and then a child Node2D. Add an internal script to the child. Duplicate the pass command in the _ready method. Hit Cmd-Z (on a Mac) to undo. The effect is to remove the child rather than the text just typed.
… On Mar 18, 2024, at 1:23 AM, Lars ***@***.***> wrote:
Also seeing this, the bug from 4.3dev3 where undo in the script editor instead undid changes in open scenes was fixed in 4.3dev4, but is now back again in 4.3dev5. Interestingly it seems specific to undo/redo. Other keyboard shortcuts like copy/paste correctly target the active script editor.
—
Reply to this email directly, view it on GitHub <#89060 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANACTMGM4X52XYXHTE6JWLYY2QA3AVCNFSM6AAAAABECIJ6C2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBTGE3TQOJWHE>.
You are receiving this because you were mentioned.
|
|
...And now it seems to be fixed. |
It looks like it was mentioned on another issue and then fixed. |
Tested versions
System information
Mac OS Sonoma 14.2.1, Intel processor
Issue description
Undo at least sometimes undoes something back in history other than the most recent change. It seems to ignore text changes and go back to a recent structural change.
Steps to reproduce
In the editor, create a Node2D. Add a script to the Node2D and, in the script editor, type in a second "pass" operation on the _ready method. Hit Cmd-Z.
In earlier versions, the second "pass" is deleted. In 4.3 Dev 3, the whole script is deleted from the Node2D
Minimal reproduction project (MRP)
N/A
The text was updated successfully, but these errors were encountered: