Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The menu bar stops appearing after saving in the fullscreen editor on Mac #86495

Closed
umutseven92 opened this issue Dec 24, 2023 · 1 comment · Fixed by #90131
Closed

The menu bar stops appearing after saving in the fullscreen editor on Mac #86495

umutseven92 opened this issue Dec 24, 2023 · 1 comment · Fixed by #90131
Labels
bug confirmed platform:macos topic:editor topic:porting
Milestone
4.3

Comments

@umutseven92
Copy link

umutseven92 commented Dec 24, 2023 •
edited
Loading

Tested versions

  • Reproducible in 4.2.1

System information

Godot v4.2.1.stable - macOS 14.2.1 - Vulkan (Forward+) - integrated Apple M1 Max - Apple M1 Max (10 Threads)

Issue description

The menu bar is the bar at the top of the screen in macOS, that shows additional menu items for the current application. When an app is windowed the menu bar is always visible, and when an app is fullscreen, the app slides into view if the user drags their cursor to the top.

With Godot, this behaviour works until the user saves the project, after which the menu bar will not appear in fullscreen. Switching to another window, then switching back to Godot fixes this, until the user saves again.

A video showing the issue is attached below:

menu-bar-bug.mov

Steps to reproduce

  • Create or load a project.
  • Make sure the editor is in fullscreen. Drag mouse to the top of the screen and see the menu bar appearing.
  • Do any change, and save using Cmd + S. Wait for the save modal to close.
  • Drag mouse to the top of the screen again, and see that the menu bar is no longer appearing.

Minimal reproduction project (MRP)

Reproducible with a new, clean project.
@Calinou
Copy link
Member

Calinou commented Jan 26, 2024

This was confirmed on the Godot Forums: https://forum.godotengine.org/t/bugs-in-macos-4-2-version/44579

@bruvzg bruvzg assigned bruvzg and unassigned bruvzg Apr 1, 2024
@rodrigodias4 rodrigodias4 mentioned this issue Apr 2, 2024
Merged
@akien-mga akien-mga added this to the 4.3 milestone Apr 4, 2024
akien-mga pushed a commit to akien-mga/godot that referenced this issue Apr 8, 2024
@rodrigodias4 @akien-mga
Fix MacOS menu bar & dock stop appearing after closing sub-window
61565d2 
When the progress dialog task for saving a scene ends, or when closing the "Open project" dialog, the DisplayServerMacOS::update_presentation_mode() method now restores those fullscreen functionalities with the flags NSApplicationPresentationAutoHideMenuBar and NSApplicationPresentationAutoHideDock, whereas before it would reset to NSApplicationPresentationDefault, which didn't allow that.

Fixes godotengine#86495

(cherry picked from commit a4f2e52)
DanielSnd pushed a commit to DanielSnd/godot that referenced this issue Apr 10, 2024
@rodrigodias4 @DanielSnd
Fix MacOS menu bar & dock stop appearing after closing sub-window
226cc03 
When the progress dialog task for saving a scene ends, or when closing the "Open project" dialog, the DisplayServerMacOS::update_presentation_mode() method now restores those fullscreen functionalities with the flags NSApplicationPresentationAutoHideMenuBar and NSApplicationPresentationAutoHideDock, whereas before it would reset to NSApplicationPresentationDefault, which didn't allow that.

Fixes godotengine#86495
divshekhar pushed a commit to divshekhar/godot that referenced this issue Apr 23, 2024
@rodrigodias4 @divshekhar
Fix MacOS menu bar & dock stop appearing after closing sub-window
ff1e7be 
When the progress dialog task for saving a scene ends, or when closing the "Open project" dialog, the DisplayServerMacOS::update_presentation_mode() method now restores those fullscreen functionalities with the flags NSApplicationPresentationAutoHideMenuBar and NSApplicationPresentationAutoHideDock, whereas before it would reset to NSApplicationPresentationDefault, which didn't allow that.

Fixes godotengine#86495
MewPurPur pushed a commit to MewPurPur/godot that referenced this issue Jul 11, 2024
@rodrigodias4 @MewPurPur
Fix MacOS menu bar & dock stop appearing after closing sub-window
baf3a90 
When the progress dialog task for saving a scene ends, or when closing the "Open project" dialog, the DisplayServerMacOS::update_presentation_mode() method now restores those fullscreen functionalities with the flags NSApplicationPresentationAutoHideMenuBar and NSApplicationPresentationAutoHideDock, whereas before it would reset to NSApplicationPresentationDefault, which didn't allow that.

Fixes godotengine#86495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed platform:macos topic:editor topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Fix macOS menu bar & dock stop appearing after closing sub-window rodrigodias4/godot
4 participants
@Calinou @umutseven92 @akien-mga @bruvzg