Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TileMap: Material changes won't update rendering if material field is empty on game start #83474

Closed
Eoin-ONeill-Yokai opened this issue Oct 17, 2023 · 0 comments · Fixed by #83475
Closed

TileMap: Material changes won't update rendering if material field is empty on game start #83474

Eoin-ONeill-Yokai opened this issue Oct 17, 2023 · 0 comments · Fixed by #83475
Labels
bug topic:2d
Milestone
4.2

Comments

@Eoin-ONeill-Yokai
Copy link
Contributor

Godot version

4.2 Beta [a574c02]

System information

Linux Fedora Silverblue

Issue description

I have a tilemap with no material assigned on start which I intend to change dynamically in-game. Changing the material field (or the equivalent call to set_material) will not reflect in a change unless you also toggle and untoggle use parent material flag.

Steps to reproduce

  • Create a tilemap w/ tileset data.
  • Create a canvas material.
  • Create a script that preloads the material and then applies the material dynamically (via key or time).
  • Observe that the tilemap does not update.

Minimal reproduction project

MaterialBug.zip -- A simple project that highlights the issue.
@Eoin-ONeill-Yokai Eoin-ONeill-Yokai mentioned this issue Oct 17, 2023
Merged
@kleonc kleonc added this to the 4.2 milestone Oct 17, 2023
ProbablyWorks pushed a commit to ProbablyWorks/godot that referenced this issue Oct 22, 2023
@Eoin-ONeill-Yokai @ProbablyWorks
Fix bug where TileMap will not update material correct on assignment
b0be4a1 
This seemed to be a simple case of a missing condition in an if
statement with a few different flags. I'm not super familiar with the
tilemap code but hopefully this is the correct place to add this check.

Fixes godotengine#83474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:2d
Projects
None yet
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

Fix bug where TileMap wouldn't update material correctly on assignment Eoin-ONeill-Yokai/godot
2 participants
@Eoin-ONeill-Yokai @kleonc