Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript being broken in many places after #72487 #72501

Closed
maiself opened this issue Feb 1, 2023 · 4 comments
Closed

GDScript being broken in many places after #72487 #72501

maiself opened this issue Feb 1, 2023 · 4 comments

Comments

@maiself
Copy link
Contributor

maiself commented Feb 1, 2023

Godot version

394bb0e

System information

arch linux

Issue description

#72487 broke my project in quite a few ways. I haven't yet had time to look into everything. Including here one example with assigning enum values.

SCRIPT ERROR: Parse Error: Invalid operands "Input::MouseMode" and "Input::MouseMode" for "==" operator.
SCRIPT ERROR: Parse Error: Cannot assign a new value to a constant.

Here is the full log output: https://pastebin.com/raw/TbdyfMSX

Steps to reproduce

Add the following code to a new project:

Input.mouse_mode = Input.MOUSE_MODE_VISIBLE

Minimal reproduction project

None yet

@maiself
Copy link
Contributor Author

maiself commented Feb 1, 2023

#72500 contains same bug.

@Chaosus
Copy link
Member

Chaosus commented Feb 1, 2023

cc @vnen

@HungryProton
Copy link
Contributor

This PR also breaks anything using get_node or $, whether @onready is used or not.

@onready var my_node = $Button

Displays this error message despite using @onready

Parse Error: The default value is using "$" which won't return nodes in the scene tree before "_ready()" is called. Use the "@onready" annotation to solve this. (Warning treated as error.)

@Chaosus Chaosus changed the title #72487 breaks various things GDScript being broken in many places after #72487 Feb 1, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in 4.x Priority Issues Feb 1, 2023
@vnen
Copy link
Member

vnen commented Feb 1, 2023

Thanks for finding this so quickly. I didn't have the time to test very thoroughly before sending the PR. I'll try to add these to the test cases when submitting a new version.

Streq pushed a commit to Streq/godot that referenced this issue Feb 9, 2023
This reverts commit a166833.

This caused multiple regressions.
Needs to be redone with more testing before merge.

Fixes godotengine#72501.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants