-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double clicking JSON files in FileSystem tab throws errors #66820
Labels
Milestone
Comments
That's due to #65295. JSON is now treated as a resource file but it's not an imported one, and apparently the FileSystem dock logic for double click doesn't know how to handle this. |
DrewV3
added a commit
to DrewV3/godot
that referenced
this issue
Oct 22, 2022
Fixes error thrown when clicking on a json file in the file dock
reduz
added a commit
to reduz/godot
that referenced
this issue
Jan 14, 2023
* It was not a resource, hence it was not working to load it as such. * Changed so, when opened in editor, a parse error will not fail load and the text will be kept. * This should allow proper editing from within the code editor, including syntax checking and saving files as-is in text. Partially addresses godotengine#66820. The code editor still needs to be changed for this to work.
Streq
pushed a commit
to Streq/godot
that referenced
this issue
Feb 9, 2023
* It was not a resource, hence it was not working to load it as such. * Changed so, when opened in editor, a parse error will not fail load and the text will be kept. * This should allow proper editing from within the code editor, including syntax checking and saving files as-is in text. Partially addresses godotengine#66820. The code editor still needs to be changed for this to work.
github-project-automation
bot
moved this from In Progress
to Done
in 4.x Priority Issues
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Godot version
v4.0.beta2.official [f8745f2]
System information
Windows 10 21H2 (Build 19044.2075)
Issue description
In beta1 was able to double click a JSON file shown in the FileSystem tab to open it in the script editor view as a text file. Doing the same in beta2 throws the following errors for the file:
Accessing the file via
FileAccess
and parsing it viaJSON.parse()
works without problems, as does dragging the file from FileSystem into the script editor's vertical tab space.Steps to reproduce
res://
Using the attached project:
res://static_data/weapons/DamageBehaviors.json
Minimal reproduction project
BugReproduction.zip
The text was updated successfully, but these errors were encountered: