Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Directional LightmapGI does not look correct with emissive surface light #64645

Closed
Tracked by #56033
atirut-w opened this issue Aug 20, 2022 · 2 comments
Closed
Tracked by #56033

Comments

@atirut-w
Copy link
Contributor

Godot version

v4.0.alpha14.official [106b680]

System information

N/A

Issue description

When using lightmap GI, specular lobes and reflections looks broken for lights from emissive objects. May be related to #63016

Cornell box model from McGuire CG Archive

2022-08-20_10-19-10.mp4

Steps to reproduce

  1. Set up a static scene with everything having their UV2 unwrapped, and preferably with only lighting from emissive objects.
  2. Add LightmapGI, enable directional mode and bake.

Minimal reproduction project

No response

@Chaosus Chaosus added this to the 4.0 milestone Aug 20, 2022
@Chaosus Chaosus moved this to To Assess in 4.x Priority Issues Aug 20, 2022
@Chaosus Chaosus moved this from To Assess to Todo in 4.x Priority Issues Aug 20, 2022
@Calinou
Copy link
Member

Calinou commented Aug 20, 2022

LightmapGI directional mode only provides rough reflections – it's not designed to provide sharp reflections like ReflectionProbe. This is done for performance reasons, as LightmapGI is something you'll most likely be using when targeting mobile.

If you need more precise reflections while using lightmaps, nothing prevents you from using VoxelGI, SDFGI or ReflectionProbe at the same time as LightmapGI. For VoxelGI and SDFGI, this will be faster than using VoxelGI/SDFGI alone as they won't affect surfaces that already receive baked lighting.

@Calinou Calinou changed the title Directional lightmap does not look correct with emissive surface light Vulkan: Directional LightmapGI does not look correct with emissive surface light Aug 20, 2022
@clayjohn clayjohn modified the milestones: 4.0, 4.x Jan 12, 2023
@Calinou
Copy link
Member

Calinou commented Aug 20, 2024

Closing in favor of #81556, which shows cases where directional lightmap rendering is actually broken and has a MRP available.

Regarding the lack of specular lobes for direct light, see #63016.

@Calinou Calinou closed this as completed Aug 20, 2024
@Calinou Calinou removed this from the 4.x milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants