Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use directional LightmapGI information to display specular lobes for fully baked (static) lights #63016

Open
jcostello opened this issue Jul 15, 2022 · 5 comments

Comments

@jcostello
Copy link
Contributor

Godot version

v4.0.alpha.custom_build [e5a1640]

System information

Ubuntu 21.04. RTX 2060

Issue description

Baked a Directional Light set as static with the LightmapGI set to directional does not bake specular information

Realtime Directional Light

image

Baked Lightmap set to directional

image

Ignore know issue about direct light power on the backed map image

Steps to reproduce

Bake lightmap set to directional on the minimal project

Minimal reproduction project

Specular.zip

@Chaosus Chaosus added this to the 4.0 milestone Jul 15, 2022
@Chaosus Chaosus moved this to To Assess in 4.x Priority Issues Jul 15, 2022
@Chaosus Chaosus moved this from To Assess to Todo in 4.x Priority Issues Jul 15, 2022
@Calinou Calinou changed the title Specular information not baked into static lights with directional LightmapGI Vulkan: Specular information not baked into static lights with directional LightmapGI Jul 15, 2022
@Calinou
Copy link
Member

Calinou commented Jul 15, 2022

Ignore know issue about direct light power on the backed map image

Can you test this with #61910 merged locally, just in case?

@jcostello
Copy link
Contributor Author

jcostello commented Jul 15, 2022

@Calinou With #61910 merged locally into master. Same result

Realtime
image

LightmapGI
image

@Calinou
Copy link
Member

Calinou commented Jul 19, 2022

I can reproduce this on the linked MRP. Directional information is present, but very subtle by default (possibly too subtle). If you increase the normal map strength to 16 in the material, you'll definitely notice that it's there:

Normal Map Strength = 1 Normal Map Strength = 16
2022-07-19_20 00 23 2022-07-19_20 00 29
Normal Map Strength = 1 Normal Map Strength = 16
2022-07-19_20 00 51 2022-07-19_20 00 57

Specular lobes don't seem to ever show up though. I doubt it was ever implemented, actually.

Minimal reproduction project (with added lights and tweaked settings): Specular2_nolightmap.zip

@Calinou Calinou added enhancement and removed bug labels Jul 19, 2022
@Calinou Calinou changed the title Vulkan: Specular information not baked into static lights with directional LightmapGI Vulkan: Use directional LightmapGI information to display specular lobes for fully baked (staic) lights Jul 19, 2022
@clayjohn clayjohn modified the milestones: 4.0, 4.x Jan 14, 2023
@Calinou Calinou changed the title Vulkan: Use directional LightmapGI information to display specular lobes for fully baked (staic) lights Use directional LightmapGI information to display specular lobes for fully baked (staic) lights May 16, 2024
@Calinou
Copy link
Member

Calinou commented Aug 20, 2024

Pages 66-77 of this slideshow describe a possible implementation of direct specular lobes using directional lightmap data.

There are some limitations with the described approach, but it has a relatively small performance impact and should have a level of quality similar or better than what's described in godotengine/godot-proposals#3078.

Edit: I've attempted implementing this in Godot but didn't get it fully working yet: https://github.com/Calinou/godot/tree/lightmapgi-directional-draw-direct-specular-lobes

@clayjohn
Copy link
Member

Pages 66-77 of this slideshow describe a possible implementation of direct specular lobes using directional lightmap data.

There are some limitations with the described approach, but it has a relatively small performance impact and should have a level of quality similar or better than what's described in godotengine/godot-proposals#3078.

Ya, that's a really nice approach when you are already baking L1 spherical harmonics

@github-project-automation github-project-automation bot moved this to For team assessment in Rendering Issue Triage Aug 20, 2024
@clayjohn clayjohn moved this from For team assessment to Up for grabs in Rendering Issue Triage Aug 20, 2024
@Calinou Calinou changed the title Use directional LightmapGI information to display specular lobes for fully baked (staic) lights Use directional LightmapGI information to display specular lobes for fully baked (static) lights Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Up for grabs
Development

No branches or pull requests

4 participants