Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when clicking a resource property in the inspector while no scene is open #60077

Closed
Zylann opened this issue Apr 9, 2022 · 1 comment · Fixed by #60500
Closed

Crash when clicking a resource property in the inspector while no scene is open #60077

Zylann opened this issue Apr 9, 2022 · 1 comment · Fixed by #60500

Comments

@Zylann
Copy link
Contributor

Zylann commented Apr 9, 2022

Godot version

4.0 83d2673

System information

Windows 10 64 bits GLES3 GeForce GTX 1060 6GB/PCIe/SSE2

Issue description

I have a resource containing another. If I open it in the inspector and click the property, Godot crashes.

image

EditorPropertyResource::_resource_selected assumes there is an open scene, causing an access violation.

Steps to reproduce

  1. Close all scenes
  2. Create a GradientTexture
  3. Assign gradient to a new Gradient in place
  4. Save the GradientTexture as a .tres file
  5. Double-click the .tres file in the file system to open it in the inspector
  6. Click the gradient property: observe a crash

Minimal reproduction project

InspectorEditSubResourceCrash.zip

@Calinou Calinou added this to the 4.0 milestone Apr 9, 2022
@timothyqiu
Copy link
Member

From #59496, CC @KoBeWi

Maybe it should skip when the resource is a builtin subresource.

@KoBeWi KoBeWi moved this to In Progress in 4.x Priority Issues Apr 24, 2022
Repository owner moved this from In Progress to Done in 4.x Priority Issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants