Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eye Icon Button is not working Godot 2.1.5 rc (regression) #17722

Closed
gerardogc2378 opened this issue Mar 23, 2018 · 15 comments
Closed

Eye Icon Button is not working Godot 2.1.5 rc (regression) #17722

gerardogc2378 opened this issue Mar 23, 2018 · 15 comments

Comments

@gerardogc2378
Copy link

gerardogc2378 commented Mar 23, 2018

Bugsquad (@Noshyaar) edit: additional details, formatting

OS/Godot Version: Arch Linux, 2.1.5-beta2, 2.1.5-rc

Issue details:

Expected: Clicking on the button hides the node, the eye shuts.
Happened: Printed "Toggle Visible", node stays visible, the eye doesn't shut.

Using Property Editor to uncheck visibility still works

Reproduction steps:

  1. New spatial node
  2. Click the eye, it will not shut, node stays visible.

peek 2018-03-24 22-05


**Godot version:** git br * 2.1 3.0 master godot $ cat version.py short_name = "godot" name = "Godot Engine" major = 2 minor = 1 patch = 5 status = "rc"

OS/device including version:
ArchLinux

Issue description:
eye icon button is not working

Steps to reproduce:
You can play with the eye icon button in your project is not working. This eye icon button is for node visibility in your current scene.

eye_icon

@akien-mga akien-mga added this to the 2.1 milestone Mar 23, 2018
@akien-mga
Copy link
Member

Can you be more specific about what you do, and what's the behaviour (as well as the behaviour you would expect)?

For me it works fine, pressing the eye icon turns off the visibility:
screenshot_20180323_175357

screenshot_20180323_175419

@ghost
Copy link

ghost commented Mar 23, 2018

lol, this is because you have a 2d node under a 3d one. if you disable the 3d node, the 2d won't be hidden with it

add your 2d node under a canvas layer (for gui stuff)

remember, think of the colors. green = 2d, red = 3d. hope that helps

@gerardogc2378
Copy link
Author

Yes, thanks, I remember the colors :-), but what about this 3d scene:

3d-scene

It's not working :-(

@ghost
Copy link

ghost commented Mar 23, 2018

what do you mean "not working"? as akien said, is it the actual button not being clicked, or when you click the eye icon it's not doing what you expected? little more specific please, not sure what issue is (sorry if language barrier)

@gerardogc2378
Copy link
Author

When you clicked the eye icon button, this is not working, this icon is for visibility :-) right? Sorry if I was incomplete for details.

@akien-mga
Copy link
Member

Can you provide an example project where it's not working? I still don't understand what's not working.

@gerardogc2378
Copy link
Author

Let me be more specific

eye-icon

This little button is not working, I mean when you click this button, this shows or hides the current node in your current scene :-)

@ghost ghost added the confirmed label Mar 24, 2018
@ghost
Copy link

ghost commented Mar 24, 2018

Edit: moved to the top for reference

Can confirm on 2.1.5 beta2

  • It happens only with Spatial nodes
  • Using Property Editor to uncheck visibility still works

Issue details:

Expected: Clicking on the button hides the node, the eye shuts.
Happened: Printed "Toggle Visible", node stays visible, the eye doesn't shut.

Reproduction steps:

  1. New spatial node
  2. Click the eye, it will not shut, node stays visible.

peek 2018-03-24 22-05

@akien-mga
Copy link
Member

akien-mga commented Mar 24, 2018

Thanks for the details, I can reproduce it too now. It worked fine in 2.1.4 so it's a regression. The bug is already present in 2.1.5-beta1, so the regression is earlier than that.

@akien-mga akien-mga changed the title Eye Icon Button is not working Godot 2.1.5 rc Eye Icon Button is not working Godot 2.1.5 rc (regression) Mar 24, 2018
@akien-mga
Copy link
Member

That's a regression from #15239, ping @sersoong.

akien-mga added a commit that referenced this issue Mar 24, 2018
@akien-mga
Copy link
Member

Fixed by 3764cf6.

@gerardogc2378
Copy link
Author

FIXED!!! Thanks everyone, I am happy again :-P

@sersoong
Copy link
Contributor

A terrible logical error.
Sorry for that.
001

@sersoong
Copy link
Contributor

How about master branch?
Does it have the same problem?

@akien-mga
Copy link
Member

No the master branch's code was correct, and it's the one your backported to the 2.1 branch - but on 2.1 the Spatial methods were different :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants