Set active in physics thread instead of play() function

Fixes pops after calling `set_stream()`
godotengine · Feb 2, 2021 · fda7066 · fda7066
1 parent 9620c1c
commit fda7066
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/scene/2d/audio_stream_player_2d.cpp b/scene/2d/audio_stream_player_2d.cpp
@@ -315,7 +315,7 @@ void AudioStreamPlayer2D::play(float p_from_pos) {
 	}
 
 	if (stream_playback.is_valid()) {
-		active = true;
+		//active = true; // setseek needs set *before* active, but that is done in the physics thread
 		setplay = p_from_pos;
 		output_ready = false;
 		set_physics_process_internal(true);

diff --git a/scene/3d/audio_stream_player_3d.cpp b/scene/3d/audio_stream_player_3d.cpp
@@ -687,7 +687,7 @@ void AudioStreamPlayer3D::play(float p_from_pos) {
 	}
 
 	if (stream_playback.is_valid()) {
-		active = true;
+		//active = true; // setseek needs set *before* active, but that is done in the physics thread
 		setplay = p_from_pos;
 		output_ready = false;
 		set_physics_process_internal(true);