Skip to content

Commit

Permalink
Raise configuration warning when PhysicsBody/2D is scaled
Browse files Browse the repository at this point in the history
This is still not supported as per #5734, even though we aim to lift
this limitation eventually.

Fixes #26890.
  • Loading branch information
akien-mga committed Jan 27, 2020
1 parent f76009b commit e04514b
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
8 changes: 8 additions & 0 deletions scene/2d/physics_body_2d.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -944,6 +944,14 @@ String RigidBody2D::get_configuration_warning() const {

String warning = CollisionObject2D::get_configuration_warning();

// Remove this if GH-5734 is fixed.
if (!get_scale().is_equal_approx(Vector2(1.0, 1.0))) {
if (warning != String()) {
warning += "\n\n";
}
warning += TTR("Scaling RigidBody2D is not supported by the physics engine and will lead to undefined behavior.\nYou may scale its parent node or sprite, but the RigidBody2D and its collision shape or polygon should have a scale of Vector2(1.0, 1.0).\nThis design limitation may be lifted in a future release.");
}

if ((get_mode() == MODE_RIGID || get_mode() == MODE_CHARACTER) && (ABS(t.elements[0].length() - 1.0) > 0.05 || ABS(t.elements[1].length() - 1.0) > 0.05)) {
if (warning != String()) {
warning += "\n\n";
Expand Down
8 changes: 8 additions & 0 deletions scene/3d/physics_body.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -915,6 +915,14 @@ String RigidBody::get_configuration_warning() const {

String warning = CollisionObject::get_configuration_warning();

// Remove this if GH-5734 is fixed.
if (!get_scale().is_equal_approx(Vector3(1.0, 1.0, 1.0))) {
if (warning != String()) {
warning += "\n\n";
}
warning += TTR("Scaling RigidBody is not supported by the physics engine and will lead to undefined behavior.\nYou may scale their parent node or mesh, but the RigidBody and its collision shape or polygon should have a scale of Vector3(1.0, 1.0, 1.0).\nThis design limitation may be lifted in a future release.");
}

if ((get_mode() == MODE_RIGID || get_mode() == MODE_CHARACTER) && (ABS(t.basis.get_axis(0).length() - 1.0) > 0.05 || ABS(t.basis.get_axis(1).length() - 1.0) > 0.05 || ABS(t.basis.get_axis(2).length() - 1.0) > 0.05)) {
if (warning != String()) {
warning += "\n\n";
Expand Down

0 comments on commit e04514b

Please sign in to comment.