Skip to content

Commit

Permalink
ResourceLoader: Let the caller thread use its own message queue override
Browse files Browse the repository at this point in the history
  • Loading branch information
RandomShaper committed Jun 13, 2024
1 parent 21c03d1 commit cc6f5d1
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions core/io/resource_loader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -302,16 +302,21 @@ void ResourceLoader::_thread_load_function(void *p_userdata) {
thread_load_mutex.unlock();

// Thread-safe either if it's the current thread or a brand new one.
CallQueue *mq_override = nullptr;
bool mq_override_present = false;
CallQueue *own_mq_override = nullptr;
if (load_nesting == 0) {
load_paths_stack = memnew(Vector<String>);

if (!load_task.dependent_path.is_empty()) {
load_paths_stack->push_back(load_task.dependent_path);
}
if (!Thread::is_main_thread()) {
mq_override = memnew(CallQueue);
MessageQueue::set_thread_singleton_override(mq_override);
// Let the caller thread use its own, for added flexibility. Provide one otherwise.
if (MessageQueue::get_singleton() == MessageQueue::get_main_singleton()) {
own_mq_override = memnew(CallQueue);
MessageQueue::set_thread_singleton_override(own_mq_override);
}
mq_override_present = true;
set_current_thread_safe_for_nodes(true);
}
} else {
Expand All @@ -324,8 +329,8 @@ void ResourceLoader::_thread_load_function(void *p_userdata) {
}

Ref<Resource> res = _load(load_task.remapped_path, load_task.remapped_path != load_task.local_path ? load_task.local_path : String(), load_task.type_hint, load_task.cache_mode, &load_task.error, load_task.use_sub_threads, &load_task.progress);
if (mq_override) {
mq_override->flush();
if (mq_override_present) {
MessageQueue::get_singleton()->flush();
}

thread_load_mutex.lock();
Expand Down Expand Up @@ -394,9 +399,9 @@ void ResourceLoader::_thread_load_function(void *p_userdata) {
thread_load_mutex.unlock();

if (load_nesting == 0) {
if (mq_override) {
if (own_mq_override) {
MessageQueue::set_thread_singleton_override(nullptr);
memdelete(mq_override);
memdelete(own_mq_override);
}
memdelete(load_paths_stack);
}
Expand Down

0 comments on commit cc6f5d1

Please sign in to comment.