Fix use-after-free in WorkerThreadPool

godotengine · Jul 27, 2024 · 795198a · 795198a
1 parent e343dbb
commit 795198a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/core/object/worker_thread_pool.cpp b/core/object/worker_thread_pool.cpp
@@ -83,6 +83,8 @@ void WorkerThreadPool::_process_task(Task *p_task) {
 	}
 #endif
 
+	bool low_priority = p_task->low_priority;
+
 	if (p_task->group) {
 		// Handling a group
 		bool do_post = false;
@@ -159,7 +161,7 @@ void WorkerThreadPool::_process_task(Task *p_task) {
 #ifdef THREADS_ENABLED
 	{
 		curr_thread.current_task = prev_task;
-		if (p_task->low_priority) {
+		if (low_priority) {
 			low_priority_threads_used--;
 
 			if (_try_promote_low_priority_task()) {