Skip to content

Commit

Permalink
C#: Hide hostfxr not found error
Browse files Browse the repository at this point in the history
Godot tries to find hostfxr in two locations, the method that tries
to retrieve the location printed an error when it was not found.
So when the first location fails it was printing an error, even if
the second location succeeded, and users were left confused thinking
there was something wrong with their installation.

Now the error will only be printed when stdout verbose is enabled.
Users will still get an error later if hostfxr is not found in any
of the two locations.
  • Loading branch information
raulsntos committed Sep 15, 2023
1 parent 7872594 commit 394c0eb
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion modules/mono/editor/hostfxr_resolver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,12 @@ bool get_dotnet_root_from_env(String &r_dotnet_root) {

bool godotsharp::hostfxr_resolver::try_get_path_from_dotnet_root(const String &p_dotnet_root, String &r_fxr_path) {
String fxr_dir = path::join(p_dotnet_root, "host", "fxr");
ERR_FAIL_COND_V_MSG(!DirAccess::exists(fxr_dir), false, "The host fxr folder does not exist: " + fxr_dir);
if (!DirAccess::exists(fxr_dir)) {
if (OS::get_singleton()->is_stdout_verbose()) {
ERR_PRINT("The host fxr folder does not exist: " + fxr_dir + ".");
}
return false;
}
return get_latest_fxr(fxr_dir, r_fxr_path);
}

Expand Down

0 comments on commit 394c0eb

Please sign in to comment.