Skip to content

Commit

Permalink
[HTML5] Raise default initial memory to 32 MiB.
Browse files Browse the repository at this point in the history
The memory was resized in any case during start.

Mitigate Chromium issue:
https://bugs.chromium.org/p/v8/issues/detail?id=11863

Also fix a warning about SAFE_HEAP being a linker only flag.

(cherry picked from commit 897c906)
  • Loading branch information
Faless authored and akien-mga committed Jul 13, 2021
1 parent 9a04e2a commit 207fb16
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions platform/javascript/detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def get_opts():
from SCons.Variables import BoolVariable

return [
("initial_memory", "Initial WASM memory (in MiB)", 16),
("initial_memory", "Initial WASM memory (in MiB)", 32),
BoolVariable("use_assertions", "Use Emscripten runtime assertions", False),
BoolVariable("use_thinlto", "Use ThinLTO", False),
BoolVariable("use_ubsan", "Use Emscripten undefined behavior sanitizer (UBSAN)", False),
Expand Down Expand Up @@ -126,7 +126,6 @@ def configure(env):
env.Append(CCFLAGS=["-fsanitize=leak"])
env.Append(LINKFLAGS=["-fsanitize=leak"])
if env["use_safe_heap"]:
env.Append(CCFLAGS=["-s", "SAFE_HEAP=1"])
env.Append(LINKFLAGS=["-s", "SAFE_HEAP=1"])

# Closure compiler
Expand Down

0 comments on commit 207fb16

Please sign in to comment.