Download: Add link for Horizon Store app on stable release #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
enhancement
topic:content
akien-mga
force-pushed
the
download-android-horizonstore
branch
2 times, most recently
from
bbcf941 to
001555f
Compare
akien-mga
force-pushed
the
master
branch
2 times, most recently
from
e99f9b8 to
7bc695b
Compare
|
What's the status on this one? should we salvage it? |
coppolaemilio
force-pushed
the
master
branch
from
d7fb26a to
f658a60
Compare
akien-mga
force-pushed
the
download-android-horizonstore
branch
from
001555f to
6fa6be7
Compare
|
Rebased and tested (on top of #1023) and it seems to work fine. Currently it shows our popup asking for donations before going to the Meta Store in the same tab, so the popup is only visible for a fraction of a second. We might want to tweak things so such external links get opened in a new tab maybe. But that shouldn't be blocking for this. |
|
yeah, I can fix the popup in a followup PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #936.
To merge only when we release 4.4-stable.
It adds a link to the
/download/androidpage which is the one used for the current stable release. Currently it's 4.3 and the Horizon Store app is 4.4.dev2.