Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply border-radius to buttons #708

Closed
wants to merge 1 commit into from
Closed

Apply border-radius to buttons #708

wants to merge 1 commit into from

Conversation

WebSnke
Copy link

@WebSnke WebSnke commented Sep 19, 2023

Before:
image

After:
image

@WebSnke WebSnke changed the title Apply border-radius to buttons Apple border-radius to buttons Sep 19, 2023
@Calinou Calinou added enhancement topic:theme Issues and PRs related to styling and scripts of the frontend labels Sep 19, 2023
@coppolaemilio
Copy link
Member

Hello there! Thanks for the contribution! Unfortunately, we can't change the style of these buttons without considering the impacts in the rest of the pages and design language currently being used.
If you want to propose a new design system you might want to start by joining our #website channel in https://chat.godotengine.org and then propose what sort of changes you would like to see and why (share mockups, etc..).

Closing this for now, but hope to see you around!

@WebSnke
Copy link
Author

WebSnke commented Sep 20, 2023

Hello there! Thanks for the contribution! Unfortunately, we can't change the style of these buttons without considering the impacts in the rest of the pages and design language currently being used. If you want to propose a new design system you might want to start by joining our #website channel in https://chat.godotengine.org and then propose what sort of changes you would like to see and why (share mockups, etc..).

Closing this for now, but hope to see you around!

@coppolaemilio
I applied the border-radius because other parts of the website already use it. That's also why I choose 7px.

The border-radius is already used in the latest news section, the donate button in the header and the feature cards:
image

@WebSnke WebSnke changed the title Apple border-radius to buttons Apply border-radius to buttons Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement topic:theme Issues and PRs related to styling and scripts of the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants