Add custom anchor to download-section.html, and use it to fix link on previews download page #1000
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preview.html There's a link at the top of the previews download page which says "Looking for a stable version? See below!" This link is supposed to scroll the page to the section lower down where you can download the stable version. However, prior to this commit, the link doesn't work because it points to an anchor that no longer exists. The link points to #stable. However, the actual anchor, as defined in download-section.html, is #call-to-action. This commit lets you set a custom anchor when you include download-section.html, and does so in preview.html to fix the broken link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #999.
There's a link at the top of the previews download page which says "Looking for a stable version? See below!"
This link is supposed to scroll the page to the section lower down where you can download the stable version. However, currently this link doesn't work because it points to an anchor that no longer exists.
The old anchor,
#stable, was removed in bb0f0a4, whendownload-section.htmlwas consolidated.This PR lets you set a custom anchor when you include
download-section.html, and does so inpreview.htmlto restore the broken link.