-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a colored speaker icon for AudioStreamPlayer
s
#9688
Comments
I don't agree, the |
This seems very straight-forward to implement, all we need is... the svgs.... |
Here are the icons I used for my screenshot. |
Just a note, it's gonna go in 4.4 due to 4.3 already being in feature freeze |
Describe the project you are working on
prototypes
Describe the problem or limitation you are having in your project
This is the "formal" proposal version of a discussion that I created a few days ago.
Those 3 icons only differ by a tiny color dot and I find them not symbolic enough to be pleasant to read.
As a bonus, the music notation used in the icon is, well, a music notation, not something related to sound in general.
Currently, the icon is made up of 2 parts:
My point of view is the following:
Describe the feature / enhancement and how it helps to overcome the problem or limitation
AudioStreamPlayer
, blue forAudioStreamPlayer2D
or red forAudioStreamPlayer3D
AudioStream
s since there is no common icon for them (some use the note, some don't)Basically use the same icon as most other software:
Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
a good icon would have to be designed by someone competent.
If this enhancement will not be used often, can it be worked around with a few lines of script?
It's used in 99% of godot projects.
Is there a reason why this should be core and not an add-on in the asset library?
it's core already
The text was updated successfully, but these errors were encountered: