Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a colored speaker icon for AudioStreamPlayers #9688

Closed
mieldepoche opened this issue May 6, 2024 · 5 comments · Fixed by godotengine/godot#92116
Closed

Use a colored speaker icon for AudioStreamPlayers #9688

mieldepoche opened this issue May 6, 2024 · 5 comments · Fixed by godotengine/godot#92116
Milestone

Comments

@mieldepoche
Copy link

Describe the project you are working on

prototypes

Describe the problem or limitation you are having in your project

This is the "formal" proposal version of a discussion that I created a few days ago.

image
image
image

Those 3 icons only differ by a tiny color dot and I find them not symbolic enough to be pleasant to read.
As a bonus, the music notation used in the icon is, well, a music notation, not something related to sound in general.

Currently, the icon is made up of 2 parts:

  1. the multi-colored note, this gradient having the "sound" meaning,
  2. a small colored play icon, colored according to the spatialness of the node.

My point of view is the following:

  • the gradient is useless. A good icon would convey the audio part much more naturally than the current design.
  • the spatial part is way too small to be useful.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

  • Use an actual speaker icon instead
  • Color it fully according to spatiality: either white for AudioStreamPlayer, blue for AudioStreamPlayer2D or red for AudioStreamPlayer3D
  • Keep the gradient in AudioStreams since there is no common icon for them (some use the note, some don't)

Basically use the same icon as most other software:

blender ubuntu unity godot, in the 3D view
image image image image

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

image

a good icon would have to be designed by someone competent.

If this enhancement will not be used often, can it be worked around with a few lines of script?

It's used in 99% of godot projects.

Is there a reason why this should be core and not an add-on in the asset library?

it's core already

@AllergenStudios
Copy link

AllergenStudios commented May 8, 2024

This is a great idea! I do also find that the differences are hard to spot, and seeing they are 2D and 3D nodes I think they should definitely be designed as one instead.

For the main audio stream player that is not 2d or 3d related, I think it should be done like the world environment
image

@mieldepoche
Copy link
Author

For the main audio stream player that is not 2d or 3d related, I think it should be done like the world environment

I don't agree, the Environment icon is blue and red because it can affect both 2D and 3D visuals (iirc), but the non-positional AudioStreamPlayer is not "both 2D and 3D", it's non-dimentional, hence the necessity for the white color imo.

@RadiantUwU
Copy link

This seems very straight-forward to implement, all we need is... the svgs....

@mieldepoche
Copy link
Author

icons.zip

Here are the icons I used for my screenshot.
They are derived from https://en.wikipedia.org/wiki/File:Speaker_Icon.svg iirc which seem to be cc0, but I don't know if they fit the godot style. The sound lines are a bit thin I think (especially compared to the AudioListener's line thickness), and I don't have the skill needed to improve them.

@RadiantUwU
Copy link

Just a note, it's gonna go in 4.4 due to 4.3 already being in feature freeze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants