Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor setting flag to disable the confirm dialog when starting a new track on the animation player #8379

Closed
securas opened this issue Nov 9, 2023 · 2 comments · Fixed by godotengine/godot#92985

Comments

@securas
Copy link

securas commented Nov 9, 2023

Describe the project you are working on

Currently, whenever creating a new track on the animation player the user is presented with this dialog window.
image

It is reminiscent of the previous dialog on Godot 2.x for the same purpose.
Despite the indication that shift can be pressed to disable it, it would be substantially better to introduce a flag in the editor settings that would disable the dialog permanently.

Describe the problem or limitation you are having in your project

Every time that a track is created, the user must either press shift, which is easily forgotten, or confirm the creation of a new track.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

An editor setting to permanently disable the dialog window, similar to what was performed in earlier versions of Godot.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

A flag can be used to turn on/off the dialog confirmation.

If this enhancement will not be used often, can it be worked around with a few lines of script?

This is an editor feature. Hence there is no script workaround.

Is there a reason why this should be core and not an add-on in the asset library?

N/A

@Calinou
Copy link
Member

Calinou commented Nov 10, 2023

See godotengine/godot#54524, which removed the previous editor setting:

The editor setting to always bypass the confirmation dialog was removed, since the new shortcut effectively supersedes it in a more granular way.

We try to keep editor settings tidy so that they're easier to navigate, so there needs to be a very good reason to readd more settings.

which is easily forgotten

The dialog tells you how to skip it every time it's displayed, so I'm not sure how it can be easily forgotten.

@securas
Copy link
Author

securas commented Nov 10, 2023

The editor settings will not be overcrowded by this setting. It was there originally placed for a reason which is not considered in https://github.com/godotengine/godot/pull/54524.

The fact that one can press shift to avoid the setting is not forgotten. However, the fact that one needs to press the shift key is easily forgotten. Once again, the dialog window was made option in 3.x for lack of practicality and poor UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants