Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing focus disabled, hovered, focused and pressed icons on alot of control themes #6579

Open
Shadowblitz16 opened this issue Mar 27, 2023 · 2 comments

Comments

@Shadowblitz16
Copy link

Describe the project you are working on

Windows95 theme

Describe the problem or limitation you are having in your project

Some styles are not possible do to the fact that some controls don't have icons and colors for some states

Describe the feature / enhancement and how it helps to overcome the problem or limitation

For example PopupMenu doesn't have any colors for icons as well as no pressed, focus or hovered icons for checkboxes and radio

Tree has same problems with all of it's icons

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Maybe a better bet would be to have a icon style resource instead of using raw images where you can have normal, focused, hovered, disabled, and pressed icons with a shadow like in #6576

If this enhancement will not be used often, can it be worked around with a few lines of script?

No

Is there a reason why this should be core and not an add-on in the asset library?

It improves theme customization of pixel art themes

@Calinou
Copy link
Member

Calinou commented Mar 27, 2023

There's a PR to add a pressed style to PopupMenu's, but it needs to be redone from scratch given PopupMenu was refactored in 4.0: godotengine/godot#29268

@Shadowblitz16
Copy link
Author

I was thinking maybe grouping font, font size, separation and spacing constants and styles under a single resource and then having that resource for all the states might be better.
That way when new controls are added the or theme styles it has to be implemented for all controls and control states

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants