Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CanvasItem's update() to redraw() for Godot 4 #5190

Closed
MewPurPur opened this issue Aug 17, 2022 · 1 comment · Fixed by godotengine/godot#64377
Closed

Rename CanvasItem's update() to redraw() for Godot 4 #5190

MewPurPur opened this issue Aug 17, 2022 · 1 comment · Fixed by godotengine/godot#64377
Labels
breaks compat Proposal will inevitably break compatibility topic:core topic:2d
Milestone

Comments

@MewPurPur
Copy link

MewPurPur commented Aug 17, 2022

Describe the project you are working on

2D Platformer, using some tool classes to draw things in the editor.

Describe the problem or limitation you are having in your project

I wrote bad logic, calling reduntantly the CanvasItem.update() method, because it was too vague. I thought it was part of Node and responsible for updating configuration warnings too. Even if I'd seen docs, the name is SO vague I might not have thought much of it.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

As suggested in old comments from Rename Tracker proposals and from godotengine/godot#64377 , rename the method to redraw().

It wouldn't solve anything in my project anymore, but it would spare future users from misunderstanding the method and making mistakes like mine.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

N/A

If this enhancement will not be used often, can it be worked around with a few lines of script?

N/A

Is there a reason why this should be core and not an add-on in the asset library?

N/A

@Calinou Calinou added the breaks compat Proposal will inevitably break compatibility label Aug 17, 2022
@Calinou Calinou added this to the 4.0 milestone Aug 17, 2022
@SilencedPerson
Copy link

I kept trying to name functions "update" only to remember it's already in use when I started with Godot.. I would appreciate this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks compat Proposal will inevitably break compatibility topic:core topic:2d
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants