Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize file matches in Quick Open Script / Quick Open Scene / Quick Open over folder matches #327

Closed
TX256 opened this issue Dec 22, 2019 · 2 comments
Milestone

Comments

@TX256
Copy link

TX256 commented Dec 22, 2019

Describe the project you are working on:
Any project applies.

Describe the problem or limitation you are having in your project:
Quick Open Script, Quick Open Type and Quick Open push folder matches to the top, even if the there is a file named with the exact filename query (without extension) in the textfield.

For example let's say I have the following files/folders:
bots/alpha/alpha.tscn
bots/beta/beta.tscn
bots/bot.tscn

Now, if I type "bot" into e.g. Quick Open Scene, the topmost entry will be "bots/alpha/alpha.tscn".

Describe how this feature / enhancement will help you overcome this problem or limitation:
This is a small usability improvement idea. To my mind/taste/preferences, it would make sense to modify the Quick Open algorithm in a way so that, if there is an exact match for a filename (without extension) - it is prioritized instead of a partial folder name match. At least, perhaps a preference could be added for this?

Show a mock up screenshots/video or a flow diagram explaining how your proposal will work:
image

Describe implementation detail for your proposal (in code), if possible:
I'm not familiar with Godot codebase.

If this enhancement will not be used often, can it be worked around with a few lines of script?:
Not applicable.

Is there a reason why this should be core and not an add-on in the asset library?:
Quick Open is a core feature already.

@KoBeWi
Copy link
Member

KoBeWi commented Dec 22, 2019

Implemented in godotengine/godot#33578, but still waits for merging.

@KoBeWi
Copy link
Member

KoBeWi commented Apr 29, 2020

The PR was merged, so this can be closed:
image

@KoBeWi KoBeWi closed this as completed Apr 29, 2020
@KoBeWi KoBeWi added this to the 4.0 milestone Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants