Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make editor dock tabs take up the whole width #2286

Open
alexfreyre opened this issue Feb 14, 2021 · 3 comments
Open

Make editor dock tabs take up the whole width #2286

alexfreyre opened this issue Feb 14, 2021 · 3 comments

Comments

@alexfreyre
Copy link

Describe the project you are working on

Some Godot UI details and the shortest PR ever!

Describe the problem or limitation you are having in your project

Why do we leave space?

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Let's make the tabs take up all the space around! They deserve it!

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

image
image

If this enhancement will not be used often, can it be worked around with a few lines of script?

According to @Calinou "this functionality must be implemented in TabContainer"

Is there a reason why this should be core and not an add-on in the asset library?

I think it is core!

@Calinou Calinou changed the title Make tabs bigger! Make editor dock tabs take up the whole width Feb 14, 2021
@Calinou
Copy link
Member

Calinou commented Feb 14, 2021

Why do we leave space?

This is an interesting question, but you'll notice that in popular GUI apps, leaving out space around tabs is pretty common. For instance, none of the major web browsers will use up all the horizontal space available when you only have a few tabs open.
(I think Safari on desktop stretched tabs to full width for a long time, but I remember them switching to a more traditional layout recently.)

Wider tabs are easier to click, but due to their varying width, they suffer from many usability issues:

  • The tab width is "unpredictable" for a casual user and may slip around when you're trying to close many tabs in a quick sucession.
  • The tab's text position will also be unpredictable in the same way, which means the user will have to spend more time to "locate" the text. This isn't really an issue in narrow docks, but it can be an issue for wide containers like the main viewport (which uses Tabs, not TabContainer).

@alexfreyre
Copy link
Author

alexfreyre commented Feb 14, 2021

This proposal don't apply for scene tabs above the viewport!

  • The other tabs can divide the space:
    1 = 100%
    2 = 50%
    3 = 33.3%

@vntxx
Copy link

vntxx commented Feb 14, 2021

How about a separate tab alignment option? I think something like "Fill" would fit quite nicely. It could then be applied to specific docks in the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants