Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for external shader editors #2179

Closed
tavurth opened this issue Jan 24, 2021 · 3 comments
Closed

Improve support for external shader editors #2179

tavurth opened this issue Jan 24, 2021 · 3 comments

Comments

@tavurth
Copy link

tavurth commented Jan 24, 2021

Describe the project you are working on

A water depth & velocity simulation shader in 2D (from above).

Describe the problem or limitation you are having in your project

I've run into many issues while dealing with Godot's shader language, and I wanted to start this post as part of my documentation of such. When dealing with the current shader implementation I feel like my hands are tied many times, which leads me to believe that the current shader implementation keeps Godot far behind other engines.

Inconsistent support for external editors

I'm primarily an Emacs user. Whenever I edit a shader file outside of Godot and I run the project, it exits with an impossible to debug C++ error. However when editing with the internal editor I have a line number error, which I can click to see the error.

This is frustrating, as Godot will never get me to switch from my primary editor, and so the inconclusive and confusing errors are a major barrier to entry.

### Describe the feature / enhancement and how it helps to overcome the problem or limitation See above

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

See above

If this enhancement will not be used often, can it be worked around with a few lines of script?

This enhancement will affect anyone who has more than a passing interest in shaders.

Is there a reason why this should be core and not an add-on in the asset library?

Shader language improvements must be core.

@Calinou
Copy link
Member

Calinou commented Jan 24, 2021

This sounds like a bug rather than a feature request, but as far as I know, external editor support was never officially implemented for shaders.

@tavurth
Copy link
Author

tavurth commented Jan 24, 2021

Ok I will post in the main repo after some time. I will finish up your comments on these posts first 👍

@tavurth tavurth changed the title [Shaders] Poor support for external editors Poor support for external editors Jan 24, 2021
@Calinou Calinou changed the title Poor support for external editors Improve support for external shader editors Jan 24, 2021
@Calinou
Copy link
Member

Calinou commented Mar 21, 2021

Closing in favor of #1466.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants