Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add left, right and bottom location options for TabContainer #1986

Open
EricEzaM opened this issue Dec 15, 2020 · 3 comments
Open

Add left, right and bottom location options for TabContainer #1986

EricEzaM opened this issue Dec 15, 2020 · 3 comments

Comments

@EricEzaM
Copy link

Describe the problem or limitation you are having in your project

More advanced usage of tabs.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Add left, right and bottom options for TabContainer

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Bottom: Visual Studio
image

Left/Right
image

If this enhancement will not be used often, can it be worked around with a few lines of script?

Basically would need to write your own tab container from scratch

@Calinou
Copy link
Member

Calinou commented Dec 15, 2020

See also godotengine/godot#4214.

Tabs on the bottom sound good, but I'm not sure if side tab locations are that useful to have in TabContainer, since this can be replicated relatively easily using themed Button nodes.

@Shadowblight
Copy link

See also godotengine/godot#4214.

Tabs on the bottom sound good, but I'm not sure if side tab locations are that useful to have in TabContainer, since this can be replicated relatively easily using themed Button nodes.

Hi, perhaps I'm a bit too ignorant, but I am requesting further clarification on this.

Aren't TabContainers on the whole just pre-packaged "themed buttons" to begin with in their current implementation on top/bottom? They're just pre-coded so we don't have to worry about doing them manually, which is largely what a game engine is supposed to do: provide ease of use for common needs in creating games. If I want left or right aligned tabs but with themed buttons as this thread suggests, it'd involve manually coding the whole concept of what the TabContainer does.

Why is it considered merited as worth it to implement TabContainers with tabs on top/bottom, but not left/right?

@Calinou
Copy link
Member

Calinou commented Nov 12, 2024

They're just pre-coded so we don't have to worry about doing them manually, which is largely what a game engine is supposed to do: provide ease of use for common needs in creating games.

As mentioned in the Best practices for engine contributors, the problem has to be complex or frequent to be worth including in core.

Remember that adding support for horizontal tab layouts is a lot more work than just allowing tabs to be placed at the top or bottom, as there is little code in common when doing this. New StyleBoxes also need to be designed for the default project theme and editor theme for horizontal tabs, which further adds to the complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants