Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify script editor and shader editor menus #10726

Open
aXu-AP opened this issue Sep 12, 2024 · 2 comments
Open

Unify script editor and shader editor menus #10726

aXu-AP opened this issue Sep 12, 2024 · 2 comments

Comments

@aXu-AP
Copy link

aXu-AP commented Sep 12, 2024

Describe the project you are working on

Godot

Describe the problem or limitation you are having in your project

Script editor and shader editor have similiar options available, but the menus are organized differently:
script
VS
shader

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Make them follow similiar logic. Exact details can be argued as long as that goal is met, but my suggestion is below.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

I suggest making the shader editor follow suit of script editor:

  • Move Online docs button the same way as in script editor for better discoverability.
  • Use more conventional menu layout (without gaps), as it works even in narrow spaces.
  • Move float button to the right.
  • Reorder: Edit should be between File and Search

EDIT: Ahh and of course I immediately after posting this understood why the menu is different: visual shader editor. Hmm, compromises are made. At least points 1 and 4 can be done. Maybe try inverting the points 2 and 3 and make script editor more similiar to shader editor?

If this enhancement will not be used often, can it be worked around with a few lines of script?

No

Is there a reason why this should be core and not an add-on in the asset library?

It's about unifying UI and making online help easier to access.

@kitbdev
Copy link

kitbdev commented Sep 13, 2024

@aXu-AP
Copy link
Author

aXu-AP commented Sep 13, 2024

Hmm, it does seem like a part of a bigger picture. For now it might be better to fix low-hanging fruit and hopefully the refactor will be finished some day (it seems that it's not actively worked on currently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants