Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples of individually setting bits in Physics introduction #9910

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Add examples of individually setting bits in Physics introduction #9910

merged 4 commits into from
Nov 20, 2024

Conversation

D4Devil
Copy link
Contributor

@D4Devil D4Devil commented Sep 5, 2024

Added examples for independently setting bits on mask and layer

@D4Devil D4Devil mentioned this pull request Sep 5, 2024
Closed
@AThousandShips AThousandShips added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:physics labels Sep 5, 2024
@D4Devil
Update physics_introduction.rst
7a6a7aa 
Added examples for independently setting bits on mask and layer
@D4Devil D4Devil force-pushed the physics-tutorial-addition branch from 1fd3ca2 to 7a6a7aa Compare September 5, 2024 19:58
@D4Devil @AThousandShips
Apply suggestions from code review
75239cd 
Applied 4 suggestions from @AThosandShips

Co-authored-by: A Thousand Ships <[email protected]>
@D4Devil
Copy link
Contributor Author

D4Devil commented Sep 5, 2024

@AThousandShips Thanks for the corrections

@AThousandShips AThousandShips requested a review from a team September 18, 2024 16:28
tetrapod00
tetrapod00 requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the code (with the function name correction applied). It does work to set the bits of the collision mask one at a time.

@tetrapod00 tetrapod00 changed the title Update physics_introduction.rst Add examples of individually setting bits in Physics introduction Nov 19, 2024
@tetrapod00 tetrapod00 merged commit 00c34dd into godotengine:master Nov 20, 2024
1 check passed
@tetrapod00
Copy link
Contributor

Thanks! And congratulations on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@tetrapod00 tetrapod00 tetrapod00 approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:physics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@D4Devil @tetrapod00 @AThousandShips