Add info to turn off preview sunlight before working with 3D shader lighting in 'Your first 3D shader'. #9897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lighting. By default in Godot 4.3, preview sunlight is enabled and only disabled by a DirectionalLight3D being added to the scene. If you follow the guide and add an OmniLight3D, the preview sunlight stays enabled and causes a drastically different look.
AThousandShips
added
enhancement
area:manual
Co-authored-by: A Thousand Ships <[email protected]>
skyace65
approved these changes
Sep 5, 2024
|
Thanks! And congrats on your first merged PR! |
mhilbrunner
pushed a commit
that referenced
this pull request
Oct 4, 2024
Add info to turn off preview sunlight before working with 3D shader lighting in 'Your first 3D shader'.
|
Cherry-picked to 4.3 in #10038. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default in Godot 4.3, preview sunlight is enabled and only disabled by a DirectionalLight3D being added to the scene. If you follow the guide and add an OmniLight3D, the preview sunlight stays enabled and causes a drastically different look compared to the images in the guide.
With preview sunlight (default).
Without preview sunlight.
Optionally also add an image to point out the toggle button;
