Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keywords for Vector in GDScript syntax highlighting #9866

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 31, 2024


  • Add Vector4 and Vector4i to syntax highlighting.
  • Removed nonexistent PackedVector2iArray and PackedVector3iArray.

@Calinou Calinou added bug cherrypick:4.1 cherrypick:4.2 cherrypick:4.3 content:website Issues related to adding website features and fixing bugs, whether on the front or back-end labels Aug 31, 2024
@mhilbrunner
Copy link
Member

Need a rebase now after the PR was merged.

- Add Vector4 and Vector4i to syntax highlighting.
- Removed nonexistent PackedVector2iArray and PackedVector3iArray.
@skyace65 skyace65 force-pushed the gdscript-lexer-fix-vector-types branch from b74a915 to 5c4342c Compare September 5, 2024 00:34
@skyace65
Copy link
Contributor

skyace65 commented Sep 5, 2024

Rebased this PR

@skyace65 skyace65 merged commit f4a38c9 into godotengine:master Sep 5, 2024
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented Sep 5, 2024

Thanks!

@Calinou Calinou deleted the gdscript-lexer-fix-vector-types branch September 16, 2024 21:24
@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.1 cherrypick:4.2 content:website Issues related to adding website features and fixing bugs, whether on the front or back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants