Add documentation for hint_enum uniform in shading_language.rst
#9841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
hint_enum uniform in shading_language.rsthint_enum uniform in shading_language.rst
AThousandShips
added
area:manual
AThousandShips
previously requested changes
Aug 26, 2024
|
Should i rebase? i seem to have committed each requested change as separate commits, also, for future reference, how can i make all requested changes in a single commit? Thank you for your guidance AThousandShips, i really appreciate it! |
|
Squashing the commits would be appreciated |
Added explanation regarding ``hint_enum`` behaviour and usage in Uniforms section. Also added a row in the Uniforms section table to reflect this new hint type This PR is documentation regarding : godotengine/godot#94324
Co-authored-by: A Thousand Ships <[email protected]>
tetrapod00
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Documentation is correct. Style looks fine.
I tested this in 4.4dev4 Compatibility with this shader, and it works as expected:
shader_type spatial;
uniform int noise_type : hint_enum("OpenSimplex2", "Cellular", "Perlin", "Value") = 0;
uniform int character_speed: hint_enum("Slow:30", "Average:60", "Very Fast:200") = 60;
void vertex() {}
void fragment() {
ALBEDO = vec3(float(noise_type)/4.0);
ALBEDO = vec3(float(character_speed)/200.0);
}
|
Thanks! And congratulations on your first merged docs pull request! |
|
Thank you ❤️❤️🥹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added explanation regarding
hint_enumbehaviour and usage in Uniforms section. Also added a row in the Uniforms section table to reflect this new hint typeThis PR is documentation regarding : godotengine/godot#94324