Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing C# code examples to documentation #9833

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Add missing C# code examples to documentation #9833

merged 1 commit into from
Aug 28, 2024

Conversation

ShawnHardern
Copy link
Contributor

Add missing C# code examples to documentation

AThousandShips
AThousandShips reviewed Aug 25, 2024
View reviewed changes
tutorials/io/runtime_file_loading_and_saving.rst Outdated Show resolved Hide resolved
tutorials/io/runtime_file_loading_and_saving.rst Outdated Show resolved Hide resolved
tutorials/io/runtime_file_loading_and_saving.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationmeshes.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationmeshes.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationmeshes.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationmeshes.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationmeshes.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationmeshes.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationmeshes.rst Outdated Show resolved Hide resolved
@ShawnHardern ShawnHardern force-pushed the update-csharp-docs branch 7 times, most recently from 102bc3d to 39c2121 Compare August 26, 2024 12:51
@ShawnHardern ShawnHardern marked this pull request as ready for review August 26, 2024 12:51
raulsntos
raulsntos requested changes Aug 26, 2024
View reviewed changes
tutorials/i18n/internationalizing_games.rst Outdated Show resolved Hide resolved
tutorials/i18n/internationalizing_games.rst Outdated Show resolved Hide resolved
tutorials/io/runtime_file_loading_and_saving.rst Outdated Show resolved Hide resolved
tutorials/io/runtime_file_loading_and_saving.rst Outdated Show resolved Hide resolved
tutorials/io/runtime_file_loading_and_saving.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationagents.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationagents.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationagents.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationagents.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationagents.rst Outdated Show resolved Hide resolved
@raulsntos

This comment was marked as resolved.

Sign in to view
@ShawnHardern
Copy link
Contributor Author

ShawnHardern commented Aug 26, 2024 •
edited
Loading

@ShawnHardern You can apply multiple suggestions at once from the Files changed tab.

Thanks just seen that now 👍😎 and thanks @raulsntos and @AThousandShips for your time reviewing this 🙏

Apologies for all the formatting changes that need to be made 🙈 when retyping and translating it across to C# I definitely miss things here and there😅

AThousandShips
AThousandShips reviewed Aug 26, 2024
View reviewed changes
tutorials/navigation/navigation_using_navigationmeshes.rst Outdated Show resolved Hide resolved
tutorials/performance/using_servers.rst Outdated Show resolved Hide resolved
tutorials/i18n/internationalizing_games.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_different_actor_locomotion.rst Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationlayers.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationlayers.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationlayers.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationlayers.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationlayers.rst Outdated Show resolved Hide resolved
tutorials/performance/using_servers.rst Outdated Show resolved Hide resolved
raulsntos
raulsntos reviewed Aug 27, 2024
View reviewed changes
tutorials/i18n/internationalizing_games.rst Outdated Show resolved Hide resolved
tutorials/io/runtime_file_loading_and_saving.rst Outdated Show resolved Hide resolved
tutorials/io/runtime_file_loading_and_saving.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationobstacles.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationobstacles.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationagents.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationagents.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationagents.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationagents.rst Outdated Show resolved Hide resolved
tutorials/navigation/navigation_using_navigationagents.rst Outdated Show resolved Hide resolved
@ShawnHardern @AThousandShips @raulsntos
Add missing C# code examples to documentation
e09439a 
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: Raul Santos <[email protected]>
raulsntos
raulsntos approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@AThousandShips AThousandShips merged commit d459bb9 into godotengine:master Aug 28, 2024
1 check passed
@AThousandShips
Copy link
Member

Thanks!

@ShawnHardern ShawnHardern deleted the update-csharp-docs branch August 30, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
enhancement topic:dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShawnHardern @raulsntos @AThousandShips @Piralein