Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C# example to Playing videos #9817

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Add C# example to Playing videos #9817

merged 1 commit into from
Aug 24, 2024

Conversation

ShawnHardern
Copy link
Contributor

Add C# examples to Playing videos

AThousandShips
AThousandShips reviewed Aug 23, 2024
View reviewed changes
tutorials/animation/playing_videos.rst Outdated Show resolved Hide resolved
tutorials/animation/playing_videos.rst Outdated Show resolved Hide resolved
tutorials/animation/playing_videos.rst Outdated Show resolved Hide resolved
tutorials/animation/playing_videos.rst Outdated Show resolved Hide resolved
tutorials/animation/playing_videos.rst Outdated Show resolved Hide resolved
tutorials/animation/playing_videos.rst Outdated Show resolved Hide resolved
tutorials/animation/playing_videos.rst Outdated Show resolved Hide resolved
tutorials/animation/playing_videos.rst Outdated Show resolved Hide resolved
@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:animation labels Aug 23, 2024
@AThousandShips AThousandShips requested a review from a team August 23, 2024 15:25
@ShawnHardern ShawnHardern force-pushed the update-playing-videos-csharp branch from 5f191b9 to 2bc1e05 Compare August 23, 2024 15:26
@AThousandShips AThousandShips changed the title Add C# examples to Playing videos Add C# example to Playing videos Aug 23, 2024
raulsntos
raulsntos reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed the code block in the Writing the Custom Shader section uses gd but it looks like we use glsl for shaders everywhere else. We may want to change it while we're updating this page.

tutorials/animation/playing_videos.rst Outdated Show resolved Hide resolved
tutorials/animation/playing_videos.rst Outdated Show resolved Hide resolved
tutorials/animation/playing_videos.rst Outdated Show resolved Hide resolved
@ShawnHardern
Copy link
Contributor Author

I also noticed the code block in the Writing the Custom Shader section uses gd but it looks like we use glsl for shaders everywhere else. We may want to change it while we're updating this page.

Great catch! ill update that too 😎

@ShawnHardern ShawnHardern force-pushed the update-playing-videos-csharp branch from 830aacc to 072984f Compare August 23, 2024 19:11
@ShawnHardern ShawnHardern requested a review from raulsntos August 23, 2024 19:11
@ShawnHardern @AThousandShips @raulsntos
Add C# examples to Playing videos
2a252ae 
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: Raul Santos <[email protected]>
@ShawnHardern ShawnHardern force-pushed the update-playing-videos-csharp branch from 3c6beb9 to 2a252ae Compare August 24, 2024 10:23
@ShawnHardern ShawnHardern requested a review from raulsntos August 24, 2024 10:24
raulsntos
raulsntos approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@AThousandShips AThousandShips merged commit 6b1bd26 into godotengine:master Aug 24, 2024
1 check passed
@AThousandShips
Copy link
Member

Thanks!

@ShawnHardern ShawnHardern deleted the update-playing-videos-csharp branch August 24, 2024 12:28
@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.1 cherrypick:4.2 enhancement topic:animation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShawnHardern @AThousandShips @mhilbrunner @raulsntos